Add Cloudflare DNS component.#15388
Merged
fabaff merged 7 commits intohome-assistant:devfrom Jul 9, 2018
ludeeus:cloudflare
Merged
Add Cloudflare DNS component.#15388fabaff merged 7 commits intohome-assistant:devfrom ludeeus:cloudflare
fabaff merged 7 commits intohome-assistant:devfrom
ludeeus:cloudflare
Conversation
ghost
added
the
houndci-bot
reviewed
Jul 9, 2018
| if result is not True: | ||
| _LOGGER.warning(result) | ||
| return True | ||
|
|
2 tasks
fabaff
previously requested changes
Jul 9, 2018
Member
fabaff
left a comment
fabaff
left a comment
There was a problem hiding this comment.
This is requires a test or needs to be added to .coveragerc.
|
|
||
| if result is not True: | ||
| _LOGGER.warning(result) | ||
| return True |
Member
There was a problem hiding this comment.
Nothing is checking this return value.
Member
Author
There was a problem hiding this comment.
That may be a side effect of me usually doing bash, where you should return a value from a funtion/method to tell the parent script that you are done.
This is not needed in Python?
Member
There was a problem hiding this comment.
No, it's not needed. It also makes the code confusing. Only return something if it's going to be used. On the other hand, if a function should return something, it should always return something. Return values should be consistent.
Member
Author
There was a problem hiding this comment.
Okei, I will add a PR to remove that line
8 tasks
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
* Add Cloudflare DNS component * Removed man * Update .coveragerc * Update cloudflare.py * Update cloudflare.py * Changed records to be required * Fix typos, update order and other minor changes
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
* Add Cloudflare DNS component * Removed man * Update .coveragerc * Update cloudflare.py * Update cloudflare.py * Changed records to be required * Fix typos, update order and other minor changes
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Add Cloudflare DNS component * Removed man * Update .coveragerc * Update cloudflare.py * Update cloudflare.py * Changed records to be required * Fix typos, update order and other minor changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This component will update all A records in the defined zone with the external IP of the host running Home Assistant.
optional: if a list list records is defined, only those wil be updated.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5723
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: